Skip to content

Simplify assertions (ShouldContainKey already checks for null) #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2023
Merged

Simplify assertions (ShouldContainKey already checks for null) #1258

merged 1 commit into from
Feb 16, 2023

Conversation

bart-vmware
Copy link
Contributor

@bart-vmware bart-vmware commented Feb 16, 2023 •
edited
Loading

QUALITY CHECKLIST

  • N/A: Changes implemented in code
  • Complies with our contributing guidelines
  • Adapted tests
  • N/A: Documentation updated

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1258 (9c0e69d) into master (ac7d3ae) will not change coverage.
The diff coverage is n/a.

❗ Current head 9c0e69d differs from pull request most recent head 8cad017. Consider uploading reports for the commit 8cad017 to get more accurate results

@@           Coverage Diff           @@
##           master    #1258   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files         243      243           
  Lines        7815     7815           
=======================================
  Hits         7244     7244           
  Misses        571      571

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bart-vmware bart-vmware marked this pull request as ready for review February 16, 2023 12:50
@bkoelman bkoelman self-requested a review February 16, 2023 13:05
@bkoelman bkoelman merged commit 0adebfd into json-api-dotnet:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkoelman bkoelman bkoelman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bart-vmware @bkoelman